-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong coordinate from genomic indels, Fix no ref/alt errors. Add genePred support to allow users to easily load their own transcripts #54
Open
davmlaw
wants to merge
47
commits into
counsyl:master
Choose a base branch
from
SACGF:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 00a2205.
… exons are just a special case of alignments with no gaps
…0dup14 should pass but c.1727_1740dup9999 should fail
…o wrong coordinates and reference allele as it treats last digit as ref digit multiplying N that many times
…s. Be able to pass in pre-calculated values to save calculation if available
…when loading in utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See test_hgvs_names for what failed and is now fixed.
Fix for #32 - Fix when no ref/alt
Fix for #50 - Fix genomic indels
Support .genePred files while keeping backwards compatability with refFlat (you never used the exon frames etc). With gff3ToGenePred (hgdownload.cse.ucsc.edu/admin/exe/linux.x86_64/gff3ToGenePred) - this drastically increases the availability of transcripts - could be used to answer/close issues #26, #28, #39, #40
Optional disabling of "indels_start_with_same_base" error
Renamed get_coords -> get_ref_coords to be more explicit